💥[BREAKING CHANGE] - Rename write_file parameters
#489
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct naming of arguments and docstring.
MiWeiss
approved these changes
Jul 31, 2024
Collaborator
|
Nice. I like it, and I am glad we do this breaking change while we're still in beta :-) Thanks |
MiWeiss
changed the title
write_file parameters
MiWeiss
added a commit
that referenced
this pull request
Jan 14, 2026
- Validate the encoding parameter before attempting to open the file. This provides a clearer error message when an invalid encoding is specified, rather than letting the error propagate from the open() call. - Fix bug from PR #489 where write_file() referenced undefined variables (parse_stack/append_middleware) instead of the renamed parameters (unparse_stack/prepend_middleware). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MiWeiss
added a commit
that referenced
this pull request
Jan 14, 2026
Fix bug introduced in PR #489 where write_file() was referencing undefined variables (parse_stack/append_middleware) instead of the renamed function parameters (unparse_stack/prepend_middleware). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MiWeiss
added a commit
that referenced
this pull request
Jan 14, 2026
Fix bug introduced in PR #489 where write_file() was referencing undefined variables (parse_stack/append_middleware) instead of the renamed function parameters (unparse_stack/prepend_middleware).
MiWeiss
added a commit
that referenced
this pull request
Jan 14, 2026
- Validate the encoding parameter before attempting to open the file. This provides a clearer error message when an invalid encoding is specified, rather than letting the error propagate from the open() call. - Fix bug from PR #489 where write_file() referenced undefined variables (parse_stack/append_middleware) instead of the renamed parameters (unparse_stack/prepend_middleware). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct naming of arguments and docstring.